Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Core - Basic ArrayBuffer support for EvaluateScriptAsync #4632

Merged
merged 1 commit into from
May 9, 2024
Merged

Core - Basic ArrayBuffer support for EvaluateScriptAsync #4632

merged 1 commit into from
May 9, 2024

Conversation

amaitland
Copy link
Member

@amaitland amaitland commented Nov 25, 2023 •
edited
Loading

Related #4358

Summary:

  • Adds ability to return an ArrayBuffer copy via EvaluateScriptAsync

How Has This Been Tested?

  • xUnit tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Updated documentation

Checklist:

  • Tested the code(if applicable)
  • Commented my code
  • Changed the documentation(if applicable)
  • New files have a license disclaimer
  • The formatting is consistent with the project (project supports .editorconfig)

@amaitland
Copy link
Member Author 

new TextEncoder().encode("Test").buffer

@AppVeyorBot
Copy link

✅ Build CefSharp 119.1.20-CI4881 completed (commit 6711bb5f29 by @amaitland)

@amaitland amaitland marked this pull request as draft January 13, 2024 06:54
@amaitland amaitland force-pushed the arraybufferEvaluateScriptAsync branch from d0b50a7 to f835a49 Compare May 8, 2024 22:35
@AppVeyorBot
Copy link

✅ Build CefSharp 125.0.80-CI5000 completed (commit 2f26f5c183 by @amaitland)

@amaitland amaitland marked this pull request as ready for review May 9, 2024 01:23
@amaitland amaitland added this to the 125.0.x milestone May 9, 2024
@amaitland amaitland merged commit dc3ec6b into cefsharp:master May 9, 2024
1 check passed
@amaitland amaitland deleted the arraybufferEvaluateScriptAsync branch May 9, 2024 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
125.0.x
Development

Successfully merging this pull request may close these issues.
2 participants
@amaitland @AppVeyorBot